Hide rooms on overview page while preview image fails to load #207
+60
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saerdnaer
approved these changes
Jan 9, 2023
|
We could add an "show all" button or switch... |
The old selector didn't match any elements on the overview page anymore, which broke the teaser image update.
This assumes that a room isn't 'live' when it is configured to have a preview image but it cannot currently be loaded.
mstock
force-pushed
the
feature/hide-previewless-rooms
branch
from
9c7a534 to
619a5fa
Compare
mstock
force-pushed
the
feature/hide-previewless-rooms
branch
from
619a5fa to
0c2cecc
Compare
|
I've given the idea with the button a try, rebased everything on the current master and force-pushed this today. Each group now gets a button which allows to toggle the display of rooms with inactive streams. |
|
@iSchluff Do you have time to resolve the merge conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the automatic update of preview/teaser images on the overview page (in the first commit) and also hides/shows rooms on the overview page depending on successful loading of the preview image, assuming that a stream is 'live' when the preview image can be loaded.
The change was inspired by a suggestion from @saerdnaer in the
#voc-lounge, where I missed the part about fixing this onmedia.ccc.deat first and implemented it for the streaming website instead, which has a somewhat similar issue - and where implementing this is probably a bit easier. I'm not sure it's a good idea though to do this on the overview page, as it renders rooms where loading of the preview image fails 'inaccessible', so I don't mind if this PR gets discarded.